Use override keyword #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
仮想関数にはvirtual, override, finalのうち適切な一つを指定する。 例外を投げないデストラクタにnoexceptを指定する。
|
ありがとうございます |
ma8ma
added a commit
to ma8ma/JDim
that referenced
this pull request
Jan 24, 2019
testブランチの更新をgtk3-previewに反映する * JDimproved#22 * JDimproved#23 * JDimproved#24 Closes #20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overrideキーワードを使ってオーバーライドされた仮想関数をマークしvirtualを外します。これにより仮想関数の作成virtualとオーバーライドoverrideを区別することができます。修正した行数が多いので後続の修正(
-Wextraとgtk3サポート)は様子を見て提出します。