Use -Wextra option #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* -Wextraで有効になる-Wunused-parameterは修正方法が複数あり 検討が必要なので暫定的に無効にする * Fix warning for 'const' type qualifier on return type has no effect
* Fix compile warning for missing field unused initializer
C++11では属性[[fallthrough]]が使えないのでGCC 7が認識するコメント[1] // fallthrough を代わりに記述し警告を抑制する [1] https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-fallthrough_003d
|
ありがとうございます。 |
ma8ma
added a commit
to ma8ma/JDim
that referenced
this pull request
Jan 24, 2019
testブランチの更新をgtk3-previewに反映する * JDimproved#22 * JDimproved#23 * JDimproved#24 Closes #20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ビルドの設定にコンパイラのオプション
-Wextraを追加しソースコードのチェックを強化します。修正した行数が多いので後続の修正(gtk3サポート)は様子を見て提出します。
-Wno-unused-parameterオプションで暫定的に無効にします。修正は未定です。Glib::StaticMutex(glibmm 2.48から非推奨)の使用をやめてstd::mutexを使うようになります。(18e0bd2)