Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if all invalid use #28

Open
noahprime opened this issue Oct 18, 2022 · 0 comments
Open

if all invalid use #28

noahprime opened this issue Oct 18, 2022 · 0 comments
Labels
invalid This doesn't seem right

Comments

@noahprime
Copy link
Collaborator

This seems to be acting as two things when it should be one. (Maybe not though I'm not sure). This parameter should only be the value to use if all points in the time series are invalid. It should not be used to replace invalid values when valid ones are present. Also, we don't need to throw an error if this is missing as long as it's not needed.

@noahprime noahprime added the invalid This doesn't seem right label Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant