Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests needed #2

Open
1 of 2 tasks
rplzzz opened this issue Dec 16, 2016 · 2 comments
Open
1 of 2 tasks

Tests needed #2

rplzzz opened this issue Dec 16, 2016 · 2 comments
Labels
Milestone

Comments

@rplzzz
Copy link
Contributor

rplzzz commented Dec 16, 2016

Some of the functionality still isn't adequately covered in the test suite. Here are some capabilities that aren't being tested:

  • transformations argument to addScenario()
  • multiple scenario outputs in getRundates()
@rplzzz rplzzz added the tests label Dec 16, 2016
@rplzzz rplzzz added this to the v1.0.0 milestone Dec 16, 2016
@pralitp
Copy link
Contributor

pralitp commented Mar 31, 2017

@rplzzz, could you elaborate on the second test here? I've added the one for transformations so I figure I might as well clear the other one out too.

@rplzzz
Copy link
Contributor Author

rplzzz commented Apr 4, 2017

I think this is referring to the fact that the case where you have a couple of scenarios in a project file with distinct run dates isn't tested. The problem is that the only way you get actual run dates in a project file is to have multiple scenarios in your GCAM output db, and the one I included in the package for testing has just one scenario. For a lot of other multi-scenario tests I can generate a test scenario and add it to the project data, but that doesn't actually give us distinct run dates.

On the other hand, since getRundates is just reading the date attribute, we probably could force a test scenario to have a date just by setting the attribute by hand in the test suite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants