Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test data out of inst #70

Open
rplzzz opened this issue Dec 22, 2019 · 2 comments
Open

Move test data out of inst #70

rplzzz opened this issue Dec 22, 2019 · 2 comments

Comments

@rplzzz
Copy link
Contributor

rplzzz commented Dec 22, 2019

Right now, the test data gets installed along with the package. However, that data is only useful for running the tests and for use in the example vignettes. The price we pay for that is that the large files prevent us from distributing rgcam on CRAN, which we might want to do someday.

What if we took the test data out of the package install directory and instead gave it a permanent home on some appropriate archive? Then the tests and the vignettes could check for the test data in a local cache, and download it if it isn't there.

Alternatively, we could put the data in a separate package, which we could include in the suggests for rgcam and continue to distribute on github.

Thoughts?

@pralitp
Copy link
Contributor

pralitp commented Dec 23, 2019

I don't mind moving it out (and maybe we could do it in such a way that we can share it with gcam_reader as well).

But we should just double check, I think we made defaults such that if you didn't specify a database (no connection nor path) it would give you the internal sample data. I don't think this is a feature we need to maintain but just something to watch out for when we do make changes. I think making this use case an error is totally appropriate.

@rplzzz
Copy link
Contributor Author

rplzzz commented Dec 23, 2019

Yes, I could live with making it an error not to specify a database. Having the default database was handy back when we were first developing the package, but at this point the test database is so limited that I can't imagine it's useful to anyone else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants