Add support for per-request expiration #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JWCook
force-pushed
the
cache-control
branch
5 times, most recently
from
a05f119
to
2971a00
Compare
* Move all expiration logic into a separate module, and add more tests * If `expire_after` is numeric, expect in in seconds instead of hours (for consistency with Cache-Control) * Add some more unit test coverage for CacheBackend
JWCook
changed the title
JWCook
added a commit
that referenced
this pull request
Apr 16, 2021
Add support for per-request expiration
JWCook
added a commit
that referenced
this pull request
May 17, 2021
Add support for per-request expiration
JWCook
added a commit
that referenced
this pull request
May 18, 2021
Add support for per-request expiration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #45 , and does some of the prep work needed for #30 and #32.
Other changes:
expire_afteris numeric, expect in in seconds instead of hours (for consistency with Cache-Control)