Fix "pointer" cursor on status indicator #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: User gets "pointer" cursor when hovering over the status indicator, even when it's green and does nothing Solution: Only apply this "pointer" cursor when in "error" state i.e. when hovering over the element does something
JWardee
approved these changes
Aug 10, 2022
|
Sounds fair to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current problem
User gets "pointer" cursor when hovering over the status indicator, even when it's green and does nothing.
It's most common for all the indicators to be green (I never knew about the error behaviour until looking at this) so it feels like something is broken when there is "pointer" cursor on the green indicators but no behaviour.
Proposed solution
Only apply this "pointer" cursor when in "error" state i.e. when hovering over the element does something.
Screenshots
Before:
After:
resolves first item of #149