Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable extended help in the search field #3599

Closed
adessec opened this issue Jan 3, 2018 · 20 comments · Fixed by #4975
Closed

Disable extended help in the search field #3599

adessec opened this issue Jan 3, 2018 · 20 comments · Fixed by #4975
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. search status: waiting-for-feedback The submitter or other users need to provide more information about the issue type: enhancement

Comments

@adessec
Copy link

adessec commented Jan 3, 2018

JabRef version <4.1> on <Linux 4.4.103-18.41-default amd64, Java 1.8.0_151>

If I start searching a database, an extended help window appears telling me that it would be possible to modify my search expression. This is rather boring when using a large database. Shouldn't there be a way to disable this feature?

Steps to reproduce:

  1. Open an existing database.
  2. Begin typing into the search window.
  3. Unwanted help appears.
@tobiasdiez
Copy link
Member

I think, this warning message can be completely removed.

@adessec
Copy link
Author

adessec commented Jan 5, 2018

I agree. More experienced users will not need it. Less experienced users may have a look at the documentation or even proceed by trial and error.

@J-Eisen
Copy link

J-Eisen commented Jan 16, 2018

I could take a look at this.

@koppor koppor added good first issue An issue intended for project-newcomers. Varies in difficulty. and removed PE1718 labels Mar 9, 2018
@stefan-kolb
Copy link
Member

What kind of help is meant here? If I start searching I don't see any additonal help messages.

@adessec
Copy link
Author

adessec commented Mar 29, 2018

It pops even up before I start typing. Just move the cursor over the search field.

@adessec adessec closed this as completed Mar 29, 2018
@adessec adessec reopened this Mar 29, 2018
@Siedlerchr
Copy link
Member

Maybe he is refering to the tooltip?

@stefan-kolb
Copy link
Member

My version does not show such a tooltip, but I remeber it...wierd

@adessec
Copy link
Author

adessec commented Mar 29, 2018

It might be meant as a tooltip but it is formatted in a different way. Background in black, smaller fonts
tooltip
.

@stefan-kolb
Copy link
Member

stefan-kolb commented Mar 29, 2018

Why don't I see your search term? This should only be shown when there is a search term in the search field. Not sure if we should remove such an information. Problem is for me it is not shown or only for a fraction of a second at all...

@stefan-kolb stefan-kolb added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Mar 29, 2018
@adessec
Copy link
Author

adessec commented Mar 29, 2018

You don't see the search term because I deleted it. The amount of bothering depends on your machine's performance. My watch says it is shown for five seconds or so.

@stefan-kolb
Copy link
Member

@JabRef/developers Does this show up for any of you? I cannot even see the message 😄

@koppor
Copy link
Member

koppor commented Mar 30, 2018

I never saw this message. Maybe, because I am using Ctrl+F

@upupming
Copy link
Contributor

I reproduced it. The message comes out after hitting "Enter" with blank input. (For just 1 second, I see)

Shall we delete this message?

@davidemdot
Copy link
Member

Hey, just to be sure, is the goal to fully remove the tooltip? I could work on it.

@tobiasdiez
Copy link
Member

Yes, I guess it can be removed completely.

@davidemdot davidemdot mentioned this issue May 14, 2019
6 tasks
@calixtus
Copy link
Member

calixtus commented May 14, 2019

Hi, i'm using Jabref since i wrote my diploma-thesis back in 2010, thanks for all of your effort put in. Im following the development-discussion since about one and a half years.
From a user perspective, deactivating the tooltip would be a pity. I agree, experienced users are annoyed, but without a tooltip I wouldn't have ever thought of searching for "editor=whoever".
Is there a chance, instead of completly disabling the tooltip, offering an option in the preferences "Disable extended help options?" This extended help could probably used in other places too, making Jabref even more accessible for Jabref-Newbies.

@tobiasdiez
Copy link
Member

@MartinKarim what's your take on this?

@tobiasdiez
Copy link
Member

Thanks to @calixtus this is now implemented in the latest development version: you can disable the tooltip in Preferences > General. Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version.

@calixtus
Copy link
Member

You're welcome. Works just fine. Did no code for years, this was fun.

@Siedlerchr
Copy link
Member

Siedlerchr commented May 18, 2019

@calixtus Feel free to contribute on other issues or to report any errors you encounter. And thanks for using JabRef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. search status: waiting-for-feedback The submitter or other users need to provide more information about the issue type: enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants