Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced abandoned JFoenix controls #10046

Merged
merged 5 commits into from
Jul 1, 2023
Merged

Replaced abandoned JFoenix controls #10046

merged 5 commits into from
Jul 1, 2023

Conversation

calixtus
Copy link
Member

@calixtus calixtus commented Jun 29, 2023

Sadly JFoenix is not developed anymore. Using JFoenix with JPMS was very clumsy.

  • Replaced call to SwingFxUtils with some native code
  • Removed JFoenix Colorpicker with vanilla
  • Replaced JFoenix Chipview with GemsFX TagView

Turn autocompletion on and restart JabRef to test this.

grafik

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@calixtus calixtus added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jun 29, 2023
@koppor koppor merged commit 4bca1b0 into main Jul 1, 2023
14 of 16 checks passed
@koppor koppor deleted the chipview branch July 1, 2023 20:16
@koppor koppor mentioned this pull request Oct 23, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
entry-editor status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants