Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline logging dependencies #1

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Conversation

koppor
Copy link
Owner

@koppor koppor commented Jul 2, 2023

Triggered by JabRef/jabref#10046

We start to use GemFX in our project:

+    implementation (group: 'com.dlsc.gemsfx', name: 'gemsfx', version: '1.74.0') {
+       exclude module: 'javax.inject' // Split package, use only jakarta.inject
+       exclude group: 'org.apache.logging.log4j'
+    }

Dependency inclusion of gemsfx should not require playing around with logging. Thus, I checked the code. The code itself uses JDK's logging framework. Only the dependencies do make use of some logging. Therefore, I removed the direct logging library requirements.

I also removed two duplicated entries in pom.xml.

@koppor koppor merged commit 8795321 into master Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant