Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore dot files #10

Closed
chevdor opened this issue Mar 26, 2021 · 3 comments
Closed

Ignore dot files #10

chevdor opened this issue Mar 26, 2021 · 3 comments

Comments

@chevdor
Copy link

chevdor commented Mar 26, 2021

I think it would be wise to ignore dot files by default.

On MacOS for instance, the OS will dump some .DS_Store all over the place and will keep doing so as long as no .DS_Store is present. Since this plugin keeps on removing them after import, that starts a nice ping-pong game :)

Today, as workaround, specific files can be ignored, that's already good.

IMHO some specific files should be ignored no matter what (ie .DS_Store) and in general, dot files should not be imported nor removed.

@chevdor
Copy link
Author

chevdor commented Mar 26, 2021

I see similar topics in #5 but my dot files definitely got imported.
image

@JackGruber
Copy link
Owner

With the commit eaeee79 the default ignore of dot files was removed, because there is no distinction between DOT file and a directory that starts with a dot.
Therefore, the correct way is to ignore .DS_Store via the settings.

@chevdor
Copy link
Author

chevdor commented Mar 26, 2021

I think it would be wise to ignore some specifix files like '.DS_Store' anyway: the users should not have to (re)define the defaults.

As far as dot files are concerned, I am sure we can end up discerning folders from files but anyway anything starting with a dot should be fignored. Dot files are system hidden files (or folders) that should be ignored by any apps unless those apps have a meaning for them.

For instance, you could expect some config in a .hotfolder file (or folder). But other than that, dot files should really not be considered nor have to be excluded manually.

What could be a cool addition once this is done however is to support things like .hotfolder_ignore or .hotfolder where users could control what will be imported and how. Many software use that: git, docker, most of the js tools, etc...

I see several benefit for those:

  • if the list is long, using a fil vs the small UI text field is more comfortable
  • the files could allow defining patterns to match tags: see example below

Sample config file .hotfolder

*.pdf pdf,document,imported
*tax*.pdf pdf,taxes,imported
*bill*.* bill
<pattern> <list of tags>

...etc...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants