Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken image (webp) displayed #13

Closed
marph91 opened this issue Jan 20, 2024 · 7 comments
Closed

Broken image (webp) displayed #13

marph91 opened this issue Jan 20, 2024 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@marph91
Copy link

marph91 commented Jan 20, 2024

I have a note with one image in the format ![alt](:/<ressource_id> "title"). In the note list preview, only the "broken image icon" is displayed. When removing the title (![alt](:/<ressource_id>)), it's displayed correctly.

It would be nice to have support for images with title.

@JackGruber
Copy link
Owner

I cannot reproduce the problem.
grafik

Are you using the latest plugin version or still 0.2.0 or less?

@marph91
Copy link
Author

marph91 commented Jan 21, 2024

I'm on plugin version 0.3.2 and Joplin 2.14.10.

Did you add the title before or after the thumbnail (in the note list preview) was created? I just tested it and it seems the bug only occurs if the title is there before the thumbnail was created.

If the title is added after the first rendering of the note list preview, the image is always displayed correctly. Even after a reboot. Maybe this is related to caching?

Edit: Can be reproduced by using the webclipper ("Clip complete page (Markdown)") on this page.

@JackGruber
Copy link
Owner

JackGruber commented Jan 21, 2024

Maybe this is related to caching?

The cache is regenerated on every Joplin start.
Only valid resources for which an image operation can be performed should be displayed.

Edit: Can be reproduced by using the webclipper ("Clip complete page (Markdown)") ....
I don't have a web clipper running, I'm not sure if I want to install it

However, you can also attach a JEX export of the note and a screenshot of the error.
Is there some error in the Joplin log?

@marph91
Copy link
Author

marph91 commented Jan 21, 2024

Here is a (shortened) version of the note (needed to zip in order to upload it): Als die Wikinger in Hamburg einfielen _ National Geographic.zip

and the corresponding screenshot:

Screenshot_20240121_221652

I couldn't see any specific error message related to this plugin.

@JackGruber JackGruber added the bug Something isn't working label Jan 22, 2024
@JackGruber
Copy link
Owner

Ok, I think the problem is that the image is a webp, I'll need to check this, but looks like the Joplin image lib can't handel this file format

@JackGruber JackGruber changed the title Support of images with title Brokem image (webp) displayed Jan 22, 2024
@JackGruber JackGruber changed the title Brokem image (webp) displayed Broken image (webp) displayed Jan 22, 2024
@marph91
Copy link
Author

marph91 commented Jan 26, 2024

Thanks for investigating and fixing! I can confirm that there are no broken thumbnails with version 0.4.0.

Is there any chance that webp images get displayed? Probably the joplin image lib would need to be extended by webp?

@JackGruber
Copy link
Owner

I was already in contact with laurent and we will check if the used libs in Joplin can support webp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants