Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine grid_vals, grid_params, grid_decisions together #23

Open
Jacob-Stevens-Haas opened this issue Mar 27, 2024 · 1 comment
Open

Comments

@Jacob-Stevens-Haas
Copy link
Owner

Jacob-Stevens-Haas commented Mar 27, 2024

Grid vals/params/decisions

It's silly that these are separate. Current implementation is that they're ordered so they can align and zip, but there's a lot of code to use one to identify values of the other like:

        plot_params = [
            param
            for decide, param in zip(grid_decisions, grid_params)
            if decide == "plot"
        ]

Proposals:

  • grid: Collection[TypedDict]
  • grid: Collection[NamedTuple]
    Should we even have plot data? It's saved in

Series data

Series data is difficult to navigate through in code, because (a) which plot/grid axis is which element of the SeriesData list is unclear (b) instead of a named tuple, we have an Annotated tuple of "metrics" and "arg_opts" inside

@Jacob-Stevens-Haas
Copy link
Owner Author

Standardizing this will also make it easier to find gridpoints based upon plot params or grid params

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant