-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Well-Understood paper to front page description #3705
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to the Website are far from pretty... but at (unfortunately) quite consistent with just how bad this code is. So those two changes are ok. Just the change to README needs improved.
README.md
Outdated
@@ -21,7 +21,7 @@ Generate all the Things! Visit [our website](https://jacquescarette.github.io/Dr | |||
|
|||
## What is Drasil? | |||
|
|||
For well understood domains, building software ought to be a matter of engineering, based on solid scientific foundations. The ultimate test of "well understood" is being able to teach the domain language to a computer. Drasil is a framework for generating all of the software artifacts for (well understood) research software, from the natural knowledge base of the domain. | |||
For well understood domains, building software ought to be a matter of engineering, based on solid scientific foundations. The ultimate test of "well understood" is being able to teach the domain language to a computer. Drasil is a framework for generating all of the software artifacts for (well understood) research software, from the natural knowledge base of the domain. The exhaustive summary of [well-understood](https://github.com/JacquesCarette/Drasil/blob/master/Papers/WellUnderstood/wu.pdf) domains and our original ideas include Drasil's primary information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than this, I would make "(well understood) research software" in the previous line be a link to the paper, and skip this whole new sentence.
There are two existing branches in my personal machine for other issues, and I will use your described tools. |
namedRef icsePositionPaper (S "Old Position Paper") +:+ S "outlining our original ideas, a" +:+ | ||
namedRef danPoster (S "Drasil Poster") +:+ S ", and a" +:+ | ||
namedRef wellUnderstoodPaper (S "Well-Understood Paper") +:+ S "discussing key concepts." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should use foldlList
, or something similar. I seem to remember describing how to do this, as well as some other improvements, in a previous PR; you can use that as reference!
Sorry everyone, there are some non-personal issues taking place on my PC, and I am going to go to repair stores tomorrow. I will get back tomorrow. |
@samm82 Newest update: have built two reusable wiki page sentences. This modification has some naming problems, and I am checking. For the Can you show me the corresponding |
Up to now my PR has a lot of commits, do not worry, later I will |
Sure, let me think about changing it (Really messy in the commit message right now) Meet some problems right now, because the squash option is disabled. Up to now I am unable to get back to my I guess the most possible case is because Dr.Carette had not merged this PR from the master's branch, but merged another now from the copy branch. @samm82 Can you give me some help to fix this? |
What is that error message from? |
@balacij you provide some great advice above. Can you or one of the summer students add this advice to our Contributor's Guide? I like your advice about squashing commits and only merging with master when necessary. Your advice on commit messages is also valuable. We might already have some of this in the Contributor's guide. |
@balacij From Git Desktop, when I switched my current branch to I tried to use commands today but it did not work. Also, when I selected multiple commits, by right-clicking, the option @JacquesCarette There is a new PR completed today, should I submit before fixing this error? |
…-and-Chunks;-Meeting-June-7th,-2023.md
…-and-Chunks,-Meeting-June-7th,-2023.md
This reverts commit ce456e6.
Fixed. Now I can squash commits, and please wait a moment. After this page, it shows that squash success, but I did not find any change on the same page (it seems like there is nothing change): |
It looks like in c6971a3 - 767c18e, you duplicated my changes in #3793 -- I don't think you needed to do this. Instead, you could have pulled in my changes from my PRs source branch. Alternatively, now, you can merge in I'm not at all familiar with GitHub Desktop, and I don't normally host office hours during the summer. However, I can try to help you here. For starters, I think you should duplicate your working branch (i.e., create a backup before making commit history changes!). Then, you can do a |
@balacij Do you have time tomorrow? Let me go to the campus if you are available, is it Ok? Right now I feel some parts of the problems I have never seen before, and I did not have enough fixing information here. |
Regrettably, that time has past. Do you have any specific topics you need help with? I could try to direct you to some resources or help you here first. |
Fixing it, but right now I spend a lot of time working with squashing commits, with many different methods' usages. However, none of them have successful results. Two used methods:
Both sides have the same result: the page just indefinitely processing, without any progresses. More information is coming. |
I'm not quite sure what squashing has to do with this using GitHub Desktop app or Cygwin. However, if you're having troubles with checking out the repo still, it is probably worth it for you to switching to a 'Linux subsystem for Windows'-based development workflow. In other words, having all development go through WSL -- thereby allowing you to checkout the one file that broke compatibility on Windows temporarily. Regarding squashing commits, you can either:
Going through (1) is surprisingly satisfying! |
@samm82 Wait a moment for the new updates.
Inherited from previous PR #3686, but with some changes. Please wait for some further checks.
Closes #3360
Newest inspection: Coding style requirements.