Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not reject promises with non-Errors #35

Closed
domenic opened this issue Nov 19, 2014 · 2 comments
Closed

Do not reject promises with non-Errors #35

domenic opened this issue Nov 19, 2014 · 2 comments

Comments

@domenic
Copy link

domenic commented Nov 19, 2014

The readme example of a jQuery-esque adapter contains

return Promise.reject(response)

This is bad practice and should not be encouraged (even though jQuery does it). Instead, it should reject with an instance of Error.
@josh
Copy link
Contributor

josh commented Nov 19, 2014

Definitely, we should axe that.

@dgraham
Copy link
Contributor

dgraham commented Nov 20, 2014

Thanks, @domenic!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@josh @dgraham @domenic