Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifying the default Set-Cookie behavior. #393

Closed

Conversation

rclmenezes
Copy link

@rclmenezes rclmenezes commented Sep 12, 2016

I'm trying to make it clear that the credentials option affects setting cookies.

Perhaps this will prevent future tickets like #386

@mislav
Copy link
Contributor

mislav commented Sep 12, 2016

Thanks for the suggestion!

Aren't the two pieces of information redundant? They basically state the same thing.

@rclmenezes
Copy link
Author

I agree that it's a little redundant.

The first section talks about differences between fetch and
jQuery.ajax. It already mentions that the default behavior of sending
cookies is different, so I figure it should mention that receiving cookies
is different as well.

The second section goes more in depth. I just wanted to copy the pattern
about sending cookies.

On Mon, Sep 12, 2016 at 3:58 PM Mislav Marohnić notifications@github.com
wrote:

Thanks for the suggestion!

Aren't the two pieces of information redundant? They basically state the
same thing.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#393 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAs-B8dfd61VN5hW7m288TyjTHPLV-A8ks5qpa7KgaJpZM4J615w
.

@@ -137,6 +137,8 @@ bear keeping in mind:
* By default, `fetch` **won't send any cookies** to the server, resulting in
unauthenticated requests if the site relies on maintaining a user session.

* By default, the **browser will not store any cookies** set in `fetch()` responses.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the two bullet points are closely related, could we collapse them into one, explaining how the browser will not handle cookies at all, either sending or receiving?

@mislav mislav closed this in 51c8c58 Nov 9, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants