It is a typo? change '=+' to '+='. #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like you are right. It seems this wans intended to limit the refresh calls. In the current code this condition is never met due to this typo. I'd have to check that reintroducing the condition doesn't have an unwanted side-effect. |
|
Hi Niko, Thanks for the reply and it’s cool to meet you on GitHub ;). From my experience this doesn’t have very much side-effect. But it’s just weird. Nan |
|
Ah, it's you :-) I'll check it out and merge. |
|
Finally had a look at this again. It seems it doesn't matter anyway if you don't have 10 keyframes or more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.