Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user I want to know reviewers are being assigned fairly #34

Open
James-Firth opened this issue Jan 7, 2019 · 2 comments
Open

As a user I want to know reviewers are being assigned fairly #34

James-Firth opened this issue Jan 7, 2019 · 2 comments
Labels
Enhancement Make an existing feature better feature request New feature or request

Comments

@James-Firth
Copy link
Owner

There's a few things I could think of to help with this:

  • Stat tracking
    • Keep track of who is assigned to PRs so we have absolute numbers on who gets assigned (and who actually reviews)
    • Maybe with a command to view it?
  • Weighted randomness
    • Make it so everyone starts evenly, then people who review less are weighted more heavily
@James-Firth James-Firth added feature request New feature or request Enhancement Make an existing feature better labels Jan 7, 2019
@kylebrownnc
Copy link

if you want to get super fancy you can possibly review number of lines changed as well instead of raw PR counts? also if they;e already approved a PR don;t count it since they're finished with that PR

@James-Firth
Copy link
Owner Author

Oh yeah that might be a good idea!

Also wonder if multiple reviews on the same PR should count as multiple or one review for the purposes of weighting. Thoughts?

I think step 1 would be tracking a bunch of data from the reviews then.
I'll see how much data I can get from the webhook (or I can always query for more data).

Data I'd like:

  • Repo owner
  • Repo name
  • Reviewer id
  • PR number
  • Review Number
  • PR Number of lines added
  • PR Number of lines removed
  • PR Total lines changed (might just calculate this)
  • Timestamp

Then it'd be easy to weight based on a variety of factors depending on what works best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Make an existing feature better feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants