Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do typos from reviews #125

Closed
JamesOwers opened this issue Jul 10, 2020 · 2 comments
Closed

Do typos from reviews #125

JamesOwers opened this issue Jul 10, 2020 · 2 comments
Assignees

Comments

@JamesOwers
Copy link
Owner

No description provided.

@JamesOwers JamesOwers added this to the Paper Camera-ready milestone Jul 10, 2020
@apmcleod
Copy link
Collaborator

The file "reviews.txt" in overleaf contains up-to date status on reviewer comments, plus some comments and discussion (from me) that aren't listed here. The main points remaining are:

And one point from me:
We may want to change the title (currently "Symbolic music correction using the MIDI degradation toolkit"). I think it is still possible to do. I'm worried that people will skip the paper if they don't work on symbolic data, and now that we have the Degrader class, and the focus is strongly on AMT data aug/noise, we don't want to miss that audience.

Some options:
"Music Correction using The MIDI Degradation Toolkit"
"Error Correction using The MIDI Degradation Toolkit"
"Musical Error Correction using The MIDI Degradation Toolkit"

@JamesOwers JamesOwers self-assigned this Jul 20, 2020
@JamesOwers
Copy link
Owner Author

Things remaining:

  • Add figure explaining pianoroll and command format and slim down text
  • Add reference "Investigating the Perceptual Validity of Evaluation Metrics for Automatic Piano Music Transcription. Transactions of the International Society for Music Information Retrieval"
  • Add columns to confusion matrix figure with results by class for tasks 3 and 4
  • Add introduction to ACME dataset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants