Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken semverGroups dependencyTypes example #127

Closed
wants to merge 2 commits into from
Closed

Fix broken semverGroups dependencyTypes example #127

wants to merge 2 commits into from

Conversation

syhner
Copy link
Contributor

@syhner syhner commented Apr 16, 2023

The example was broken, as devDependencies and peerDependencies should be referenced in dependencyTypes using dev and peer respectively.

See https://jamiemason.github.io/syncpack/config/version-groups#dependencytypes-string

@JamieMason
Copy link
Owner

Thanks a lot @syhner, will merge this soon

JamieMason pushed a commit that referenced this pull request May 28, 2023
@syhner @JamieMason
docs(website): fix broken config examples
9fc6c2a 
Closes #127
JamieMason pushed a commit that referenced this pull request May 28, 2023
@syhner @JamieMason
docs(website): fix broken config examples
dc6c23c 
Closes #127
@JamieMason JamieMason deleted the branch JamieMason:master May 28, 2023 11:03
@JamieMason JamieMason closed this May 28, 2023
@JamieMason
Copy link
Owner

Merged and credited, thanks a lot for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@syhner @JamieMason