Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pnpm support #42

Closed
wants to merge 6 commits into from
Closed

pnpm support #42

wants to merge 6 commits into from

Conversation

aparajita
Copy link
Contributor

Description (What)

This PR adds support for pnpm workspaces. This was accomplished by using get-packages to get the list of pnpm workspace packages.

Note that get-packages searches the directory hierarchy for the closest pnpm-workspace.yaml file, starting from the current working directory, so the behavior is a little different for pnpm than it is for npm/yarn. I would argue that being able to run syncpack from anywhere within a monorepo is actually a nice feature.

Justification (Why)

pnpm is the "other" package manager which is already in heavy use by organizations like Microsoft and is growing in popularity. Many who use it say it has best-in-class support for monorepos. Thus it seemed natural to add pnpm support to syncpack.

How Can This Be Tested?

cd /path/to/some/dir
git clone https://github.com/JamieMason/syncpack.git
cd syncpack
npm run build
cd ..
git clone https://github.com/pnpm/pnpm.git
cd pnpm
git checkout acb74df703e29c0c340071d71d7687cbc7ff07af
node ../syncpack/dist/bin.js list | wc -l
# result should be 298

@JamieMason JamieMason closed this in a6112ec Aug 2, 2020
@JamieMason
Copy link
Owner

Thanks a lot for this @aparajita, this has been released in syncpack@5.1.4

@aparajita
Copy link
Contributor Author

Thank you! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants