Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Taste for blood 9sec sometimes instead of 6sec #252

Closed
Shintaxgg opened this issue Aug 4, 2022 · 13 comments
Closed

[BUG] Taste for blood 9sec sometimes instead of 6sec #252

Shintaxgg opened this issue Aug 4, 2022 · 13 comments

Comments

@Shintaxgg
Copy link

1. Current Behavior

1.1. Description

Taste for blood proc every 9sec sometimes instead of 6sec

1.2. How to Reproduce

       1. Rend a target with the talent taste for blood
       2. Notice sometimes taste for blood proc every 9 seconds instead of 6sec

1.3 Source Material

https://www.youtube.com/watch?v=ZEaX6fyO-b0

2. Expected Behavior

2.1. Description

Should proc every 6 seconds

2.2 Source Material

Not yet

@deanced
Copy link

deanced commented Aug 4, 2022

Per the talent: Whenever your Rend ability causes damage, you have a 33% chance of allowing the use of your Overpower ability for 9sec. This effect will not occur more than once every 6 sec.

This ability has a 33% chance to proc on every rend tick, and has a 6 sec. internal CD, that does not mean it will proc every 6 sec. it merely means that's when it's available to proc again. This is not a bug.

@caccavale caccavale closed this as not planned Won't fix, can't repro, duplicate, stale Aug 4, 2022
@Shintaxgg
Copy link
Author

You realise 3 points in it makes it 100% right, lol

@deanced
Copy link

deanced commented Aug 4, 2022

No you're right, that's my bad. I can also see what's happening on it looking at my own combat log now, it appears to be resetting the ICD based on when you use the proc, and not when the proc actually happens.

@caccavale
Copy link
Collaborator

caccavale commented Aug 4, 2022

I closed for no expected behavior reference and low quality info. Can we improve the quality of this ticket?
@magey perhaps 👀

@CharWS
Copy link
Collaborator

CharWS commented Aug 4, 2022

as per the video here: https://www.youtube.com/watch?v=l7wqOhHNSz4&t=60s
can see that this behavior while strange does appear to match the original behavior in wotlk
0:59 (59.28) - rend applied
1:02 (62.41) - rend damage [1471]
1:05 (65.49) - rend damage [1471] + tfb proc
1:08 (68.25) - rend damage [1471]
1:11 (71.33) - rend damage [1471] - where tfb proc??
1:14 (74.41) - rend damage [1471] + tfb proc

@caccavale caccavale reopened this Aug 4, 2022
@caccavale
Copy link
Collaborator

Welp, that was a ride.

@caccavale caccavale closed this as not planned Won't fix, can't repro, duplicate, stale Aug 4, 2022
@caccavale
Copy link
Collaborator

Current beta log showing ^ behavior
image

@Shintaxgg
Copy link
Author

So this is a bug that existed back in the day, so it's technically NAB ( there's multiple evidences such as the 3.3.5a video in the post)

That said it's clearly one of those bad and clearly unintended bug that we reckon should be corrected.

@JamminL JamminL added the Warrior Warrior related bugs label Aug 6, 2022
@JamminL
Copy link
Collaborator

JamminL commented Aug 6, 2022

So this is a bug that existed back in the day, so it's technically NAB ( there's multiple evidences such as the 3.3.5a video in the post)

That said it's clearly one of those bad and clearly unintended bug that we reckon should be corrected.

lol.

Regardless of the sassyness of that copypaste, its still a fair point. This was probably an unintentional bug so reopening until we hear a final decision.

@Aggrend
Copy link
Collaborator

Aggrend commented Aug 23, 2022

This does in fact match 3.3.5, however I'll acknowledge that this was likely not intended and as a result we've dug into it pretty deeply and determined that its a pretty risky code change if we wanted to attempt a fix at this point. We are going to say NAB/WNF for now. We have a bug in our DB and might revisit it in the future, however. Thanks!

@knasen88
Copy link

Thanks for confirming but could you maybe elaborate for us? it's hard to cope with what seems like such an easy fix of e.g just lowering the CD to 5.9 seconds being a risky change? #59 seems more intricate but got fixed rather quickly.

@stako
Copy link

stako commented Aug 24, 2022

Looks like they did just that for Cataclysm - reduced the cooldown to 5 seconds. Doesn't actually allow you to get an overpower proc every 5 seconds as rend ticks every 3 seconds, so it's still gonna proc every 2nd tick (6 seconds), just fixes the missed procs. Unless players start refreshing rend at weird times, but that'd almost certainly be a DPS loss.

@concerned-warrior
Copy link

Any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants