Wifi segment #1262
Wifi segment #1262
Conversation
| if !w.env.hasCommand(cmd) { | ||
| return false | ||
| } | ||
| cmdResult, err := w.env.runCommand(cmd, "wlan", "show", "interfaces") |
There was a problem hiding this comment.
this won't work cross platform so if you want to contribute this, you need to find a way that works everywhere ;-)
There was a problem hiding this comment.
Sorry, I didn't see these comments. I meant to push the PR to my own repo so I could run the GitHub Actions.
I have a new PR that I just submitted. But it will have this same limitation. Testing this feature is impossible without a physical Linux machine with an actual WiFi network interface. Virtual Linux environments don't have that.
What other things could I do? I noticed the spotify segment has some compilation hints that allows them to have Windows, Linux, and WSL specific implementations. I was thinking of doing something like that, and just excluding Linux/Darwin for now.
| return false | ||
| } | ||
|
|
||
| regex := regexp.MustCompile(`(.+) : (.+)`) |
There was a problem hiding this comment.
we also have regex helpers for this (we cache the compilations), see regex.go for more information.
There was a problem hiding this comment.
Oh nice. I will look into that and update my other PR.
| } | ||
|
|
||
| func (w *wifi) string() string { | ||
| segmentTemplate := w.props.getString(SegmentTemplate, "{{.SSID}} {{.SignalStrength}} {{.ReceiveRate}}Mbps") |
|
Here is the actual PR with a bunch more work on it! Or should we close the other one and re-open this one?? I don't have the ability to Reopen. The button is greyed out. |
Prerequisites
CONTRIBUTINGguideDescription
[Description of the change]