Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Skin preview is broken when the skin has only one layer #192

Closed
jimchen5209 opened this issue Nov 29, 2018 · 6 comments
Closed

[Issue] Skin preview is broken when the skin has only one layer #192

jimchen5209 opened this issue Nov 29, 2018 · 6 comments

Comments

@jimchen5209
Copy link

Using blockbench desktop app version 2.1.0 on Windows 10 Home version 1803

I was changing the display skin in preview setting, when I change in to some player's skin which only has one layer, the preview is broken.
If I use the skin which has two layers, it previews normally.

Skin which has only one layer:

Used skin player: MHF_Herobrine
It suppose to be: Herobrine
Screenshots:
default
default

Skin which has two layers:

Used skin player: jimchen5209
Screenshot:
default

@JannisX11
Copy link
Owner

The skin you tested uses the old skin mapping system. Generally, skins without layers are supported but they have to be in the new post 1.7 format. There are no plans to support the old format.

@vrad-exe
Copy link

vrad-exe commented Nov 2, 2020

Can the old skin layout please be supported? I use it sometimes for compatibility with older versions of the game, but that means Blockbench won't render my skin properly. I doubt it would be very difficult to add support for this - just check the image dimensions, if it's the old size then disable the secondary layers, and mirror the right arm/leg for the left ones.

@JannisX11
Copy link
Owner

Can the old skin layout please be supported? I use it sometimes for compatibility with older versions of the game, but that means Blockbench won't render my skin properly. I doubt it would be very difficult to add support for this - just check the image dimensions, if it's the old size then disable the secondary layers, and mirror the right arm/leg for the left ones.

Just to make sure, are you talking about skins in display mode or about the skin editor?

@vrad-exe
Copy link

vrad-exe commented Nov 2, 2020

The display preview. I didn't even know there was a "skin editor", I'm assuming that's for Bedrock entities or something?

@JannisX11
Copy link
Owner

There is a skin editor that works for both Minecraft editions and for both skins and most entities.
I definitely won't be adding support for the old skin format in display mode.

@vrad-exe
Copy link

vrad-exe commented Nov 2, 2020

Why not, is it really that difficult or time-consuming?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants