Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PacketGiveRewards modifies the world off of the main thread #17

Closed
Aaron1011 opened this issue May 10, 2019 · 0 comments
Closed

PacketGiveRewards modifies the world off of the main thread #17

Aaron1011 opened this issue May 10, 2019 · 0 comments

Comments

@Aaron1011
Copy link

The handler for PacketGiveRewards modifies Minecraft game objects (modifiying players and executing commands ) directly from a netty thread. Since none of the core Minecraft objects are thread-safe, this can easily lead to world corruption.

Instead, PacketGiveRewards should create a scheduled task (via MinecraftServer#addScheduledTask, and perform all of its actions from within that task.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Aaron1011