Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uPortal fails with Java 8 version above 255 #468

Closed
cbeach47 opened this issue Aug 19, 2020 · 4 comments · Fixed by uPortal-Project/uPortal#2157
Closed

uPortal fails with Java 8 version above 255 #468

cbeach47 opened this issue Aug 19, 2020 · 4 comments · Fixed by uPortal-Project/uPortal#2157

Comments

@cbeach47
Copy link
Contributor

Describe the bug
Running uP-start with versions of Java 8 greater than 255 fails on login with the error. Might be uP core's issue. Will need some investigation.

Caused by: java.lang.IllegalArgumentException: Invalid version number: Version number may be negative or greater than 255
	at com.ibm.icu.util.VersionInfo.getInstance(VersionInfo.java:191)
	at com.ibm.icu.impl.ICUDebug.getInstanceLenient(ICUDebug.java:65)
	at com.ibm.icu.impl.ICUDebug.<clinit>(ICUDebug.java:69)

Note: https://communities.bmc.com/docs/DOC-129065

To Reproduce
Steps to reproduce the behavior:

  1. Upgrade Java to 8u265 (I used SDKMan)
  2. Start uPortal
  3. Access http://localhost:8080/uPortal/Login?userName=admin&password=admin
  4. Note error

Expected behavior
It should not fail.

Platform:

  • uPortal Version: [uPortal 5.8.2]
  • OS: [Ubuntu 16.04]
  • Browser [Firefox]

Additional context
Workaround is to downgrade Java8 to something below 255.

@jgribonvald
Copy link
Contributor

jgribonvald commented Aug 20, 2020

This problem come from icu4j dependency used in uPortal here:

uPortal-web/src/main/java/org/apereo/portal/web/view/GoogleHtmlDataTableView.java:import com.ibm.icu.util.ULocale;
uPortal-web/src/main/java/org/apereo/portal/web/view/GoogleCsvDataTableView.java:import com.ibm.icu.util.ULocale;

and seems to be a transient dependency used by com.google.visualization:visualization-datasource

The problem of this lib is there isn't upgrade since 8 years, expect on some forks...

So I would suggest to find an alternative of this lib and to remove it.

In waiting this fork could suit the needs: https://github.com/ci-rt/google-visualization-java

and we have to change the dependency to com.github.ci-rt:visualization-datasource:1.1.3

PS: this issue is a uPortal issue and not a uPortal-start one ;)

@nickwoodle
Copy link

Are there any updates on this issue or has it been moved over to uPortal like Julien suggested?

@jgribonvald
Copy link
Contributor

doing the change with the forked lib is not difficult, but doing the test is the difficulty for me as I don't know how to use these views quickly. Is there someone who know ?

ChristianMurphy added a commit to ChristianMurphy/uPortal that referenced this issue Sep 4, 2020
resolves uPortal-Project/uPortal-start#468

Co-authored-by: Julien Gribonvald <julien.gribonvald@gmail.com>
@ChristianMurphy
Copy link
Member

Thanks for reporting @cbeach47!
And for tracking down the root cause @jgribonvald!

I've opened two PRs to address this uPortal-Project/uPortal#2157 and #471.
I tested locally with:

openjdk version "1.8.0_265"
OpenJDK Runtime Environment Corretto-8.265.01.1 (build 1.8.0_265-b01)
OpenJDK 64-Bit Server VM Corretto-8.265.01.1 (build 25.265-b01, mixed mode)

@jgribonvald @nickwoodle @cbeach47 if you could take it for a test drive and ensure it works in your environment/preferred JDK, it would be appreciated. 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants