-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new design #66 #70
new design #66 #70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rocktimsaikia: I really like this new design. The linear gradients are really striking. I have included some changes, with most of them just being cleanup.
A few changes I haven't included in the comments below as they could be their own issues:
back to search
button text color is not easily readable against the gradient:
.
It should match the style of theCheck them out
buttons.- Hovering over the buttons shows the unrounded form of the rectangular button.
I am really impressed otherwise. I advise just making the changes requested, but if you feel up to it, then make the two changes above as well. If not, then a new issue could be created from them and offered to someone else.
Thanks for contributing! I am looking forward to seeing this merged in.
Can you also offer your opinion on this PR @JasonFritsche?
@cdrani Thanks for the review i will make your requested changes asap 😊 |
@cdrani hi I made the requested changes that you mentioned. So again here is the overview of the new changes i made :
A few new changes I made :
Here is the changed homepage with the white colored input field : |
…ad of ids,import instead of require
@rocktimsaikia Thanks for your contributions to the project. This is an awesome addition. |
I am glad i could use this holiday season working on open source rather than my college stuff :) |
Feel free to make more PR's. If you see a bug or feature that is not in the current set of issues then feel free to open a new issue. Thanks! |
Hi in this pull request I made few changes in the overall home page design .All the designs specs is based on the issue #66 that I opened few days ago.
So again these are the things i worked on :
here is the final result :
Please let me know what you guys think of these chnages .