-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add orchid sbt plugin #328
Conversation
My initial review of this is looking great! While I don't know Scala, the plugin looks like it's set up and configuring Orchid correctly, and the test script is working perfectly. For documentation, let's add it as a section to the end of this file instead of having a README in the SBT project root. Within that file, you can use
The only other thing I see is that it needs an |
I've implemented an sbt has its own command line, on which you can now do...
But you can also use it from the command line:
or just
|
…main/orchid/resources', rather than just 'src/main/orchid' to better mirror other environments.
…tion in a proper place.
OK. I think I've put the documentation where it goes, and gotten rid of the awkward self-updating To be more consistent with everything else, I also modified the conventional source directory from |
Alright, I've finally gotten time to go through this PR thoroughly, and it's working perfectly! It took a little bit of work to get it published to Bintray properly, but I was able to get it published successfully, and then also successfully used the quickstart docs to run the plugin in another project! I've gone ahead and squashed the commits and manually applied them to the Thanks again for your incredible work here, I'm really excited to get this released! Might have to start looking into adding support for Scala code docs soon, too 😉 |
(Sorry about the zillion tiny commits. It's lazy, but easy to use github as a markdown renderer when messing with documentation!) |
No worries, I tend to do the same thing. This has been released now as version 0.17.7, and docs are updated. |
Hopefully the scripts are as expected.
test.sh
doesn't say very much, but it will succeed with exit value 0, or fail with exit value 1 iff its (very basic) tests fail.I haven't tested
deploy.sh
against an actual bintray repository, I just watch it fail for lack of authentication. I hope it's set up okay when credentials are available, though I'll not be surprised if I've screwed something up.The
README.md
file remains the documentation, but in order to keep the version there in sync I have it regenerate itself on each build. This seems... awkward. It will be easy to excise all that when the documentation finds a better home.