Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the two missing delegate properties #15

Merged
merged 2 commits into from
Oct 5, 2015
Merged

Add the two missing delegate properties #15

merged 2 commits into from
Oct 5, 2015

Conversation

orta
Copy link
Contributor

@orta orta commented Oct 2, 2015

Looks like the additions of some new protocol didn't get corresponding properties, so if you were using any of the APIs further down the indexes were not congruent with JSApplicationDelegateSubprotocols.

@JaviSoto
Copy link
Owner

JaviSoto commented Oct 5, 2015

Ooops nice catch!!

JaviSoto added a commit that referenced this pull request Oct 5, 2015
@JaviSoto
Merge pull request #15 from orta/patch-1
ebfb128 
Add the two missing delegate properties
@JaviSoto JaviSoto merged commit ebfb128 into JaviSoto:master Oct 5, 2015
@robinsenior
Copy link
Contributor

Ah, thanks for spotting that @orta, my mistake

@robinsenior
Copy link
Contributor

@JaviSoto will you be doing a new cocoapods release for the iOS 9 features?

@JaviSoto
Copy link
Owner

JaviSoto commented Oct 7, 2015

Yes, let me get on to that.

@JaviSoto
Copy link
Owner

JaviSoto commented Oct 7, 2015

The podspec fails to validate, all I see are these warnings:

-> JSDecoupledAppDelegate (1.2.0)
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:36:27: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:106:145: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:106:187: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:106:226: warning: block pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:113:36: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:113:99: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:116:36: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:116:87: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:116:142: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:116:181: warning: block pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:120:36: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:120:151: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:120:197: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:120:236: warning: block pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:128:21: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:128:50: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:128:117: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:128:155: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:129:36: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:129:86: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:130:36: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:130:89: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:131:36: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:131:94: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:132:36: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:132:93: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:138:36: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:138:65: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:138:99: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:138:131: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:140:36: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:140:57: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:140:100: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:148:36: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:148:106: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:148:145: warning: block pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:156:68: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:164:70: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:165:67: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:172:36: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:172:95: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:172:134: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:172:118: warning: block pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:179:36: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:179:96: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:186:36: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:186:93: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:187:36: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:187:87: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:187:138: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:187:127: warning: block pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:188:36: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:188:98: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:188:132: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:189:36: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  |  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.h:189:88: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]
    - WARN  | [iOS]  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.m:207:1: warning: conflicting return type in implementation of 'application:supportedInterfaceOrientationsForWindow:': 'UIInterfaceOrientationMask' (aka 'enum UIInterfaceOrientationMask') vs 'NSUInteger' (aka 'unsigned int') [-Wmismatched-return-types]
    - NOTE  |  /Applications/Xcode7.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.0.sdk/System/Library/Frameworks/UIKit.framework/Headers/UIApplication.h:336:1: note: previous definition is here
    - WARN  | [iOS]  JSDecoupledAppDelegate/JSDecoupledAppDelegate/JSDecoupledAppDelegate.m:207:1: warning: conflicting return type in implementation of 'application:supportedInterfaceOrientationsForWindow:': 'UIInterfaceOrientationMask' (aka 'enum UIInterfaceOrientationMask') vs 'NSUInteger' (aka 'unsigned long') [-Wmismatched-return-types]

[!] The podspec does not validate.

Are those the reason why it doesn't validate?
I can fix those issues on the header, but not until later today.

@robinsenior
Copy link
Contributor

Ugh, yeah, if you add one nullability qualifier, you need to add them all. Are there any issues adding the qualifiers for people who aren't on Xcode 7?

@JaviSoto
Copy link
Owner

JaviSoto commented Oct 7, 2015

Yeah, it breaks their build lol. I can add them conditionally though. I'll try to do this later.

@orta
Copy link
Contributor Author

orta commented Oct 7, 2015

you can use --ignore warnings to ignore the warnings from Xcode and ship the pod anyway, which in this case makes sense, though supporting XC7+ is probably reasonable, given how the library works and why anyone would update.

@robinsenior
Copy link
Contributor

it also looks like there are some duplicate #endifs in there, probably copypasta or a bad merge. If you're fixing the nullability qualifiers you can clean those up too.

@JaviSoto
Copy link
Owner

JaviSoto commented Oct 7, 2015

I'm working on this now.

Which are duplicate?

@JaviSoto
Copy link
Owner

JaviSoto commented Oct 7, 2015

I fixed all the warnings, but pod trunk push seems to be checking an older version for some reason...
I'll use --ignore-warnings.

@JaviSoto
Copy link
Owner

JaviSoto commented Oct 7, 2015

OK It's pushed as 1.2.0 with these changes: 8489a4c :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orta @JaviSoto @robinsenior