Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

long handling in python3 #57

Closed
Jaymon opened this issue Dec 24, 2017 · 0 comments
Closed

long handling in python3 #57

Jaymon opened this issue Dec 24, 2017 · 0 comments
Labels

Comments

@Jaymon
Copy link
Owner

Jaymon commented Dec 24, 2017

In order to get around the lack of a long in python3, compat does this:

class long(int): pass

but long is used by the prom.Field to create BIGINT fields in python2, the problem is that int in python3 is the same as long in python 2 (so there isn't really a way to create BIGINT fields in python 3 without doing something like:

from prom.compat import long
from prom import Field

some_field = Field(long)

which seems horrible and is definitely counter-intuitive. I'm wondering if it is worth just making all integers BIGINT in python 3?

@Jaymon Jaymon added the py3 label Dec 24, 2017
@Jaymon Jaymon changed the title compat currently creates a long long handling in python3 Dec 24, 2017
@Jaymon Jaymon mentioned this issue Oct 16, 2021
@Jaymon Jaymon closed this as completed in 84d5268 Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant