-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add vocolinc flowerbud chars #23
Conversation
Codecov Report
@@ Coverage Diff @@
## main #23 +/- ##
==========================================
- Coverage 85.04% 85.03% -0.02%
==========================================
Files 45 45
Lines 3270 3281 +11
==========================================
+ Hits 2781 2790 +9
- Misses 489 491 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
aiohomekit/model/services/service.py
Outdated
@@ -41,7 +41,10 @@ def filter(self, char_types=None) -> Iterable[Characteristic]: | |||
matches = iter(self) | |||
|
|||
if char_types: | |||
char_types = [CharacteristicsTypes.get_uuid(c) for c in char_types] | |||
char_types = [ | |||
(c if len(c) == 36 else CharacteristicsTypes.get_uuid(c)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do this normalisation in get_uuid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I originally had it there. I will add it back and update the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant, thank you. When that's done I can push a tag/pypi release with it merged for you if you'd like?
Are you planning to add these to HA? There is not really a good story for vendor extensions there yet. I guess the vague plans are:
|
@Jc2k I am planning on utilizing this in HA. I have 2 PRs pretty much ready to go, but is related to this PR and utilizes vendor specific chars.
They both will map to the humdifier entity in HA. |
Nice! Sounds like it aligns with my thinking on case 2 then! Great news, i look forward to reviewing those PR's as well! |
I've run out of time tonight but I'll try and push out a tag tomorrow. |
@Jc2k Can you tag a new release? I have the PR ready for this in HA. |
This product has some custom characteristics to operate as a diffuser, despite being classified as a humidifier. This adds the ability to use these characteristics.