Add HomeKit Controller Diffuser #42676
Conversation
Co-authored-by: Quentame <polletquentin74@me.com>
Co-authored-by: Quentame <polletquentin74@me.com>
…/adrum/home-assistant into add-homekit-humidifer-dehumidifier
…midifier-diffuser # Conflicts: # homeassistant/components/homekit_controller/humidifier.py
…midifier-diffuser # Conflicts: # tests/components/homekit_controller/test_humidifier.py
|
aiohomekit 0.2.55 released with the changes you need. |
…midifier-diffuser
# Conflicts: # homeassistant/components/homekit_controller/manifest.json # requirements_all.txt # requirements_test_all.txt
|
Parent PR merged. |
# Conflicts: # homeassistant/components/homekit_controller/humidifier.py # tests/components/homekit_controller/test_humidifier.py
tests/components/homekit_controller/specific_devices/test_vocolinc_flowerbud.py
Outdated
Show resolved
Hide resolved
|
I've put together a PR (#43242) for the idea i mentioned on your PR - passing the aiohomekit models around instead of the raw JSON data. I think it makes the @callback
def async_add_service(service):
if service.short_type != ServicesTypes.HUMIDIFIER_DEHUMIDIFIER:
return False
info = {"aid": service.accessory.aid, "iid": service.iid}
entities = []
if service.has(CharacteristicsTypes.Vendor.VOCOLINC_HUMIDIFIER_SPRAY_LEVEL):
entities.append(VocolincFlowerbud(conn, info))
else:
if service.has(CharacteristicsTypes.RELATIVE_HUMIDITY_HUMIDIFIER_THRESHOLD):
entities.append(HomeKitHumidifier(conn, info))
if service.has(
CharacteristicsTypes.RELATIVE_HUMIDITY_DEHUMIDIFIER_THRESHOLD
):
entities.append(HomeKitDehumidifier(conn, info))
async_add_entities([entities], True)
return TrueWhat do you think? Unfortunately black still makes it look ugly because of the long characteristic name. |
|
When will the Diffuser be added to the production version of Home Assistant? |
|
The answer to that question is always "when it's ready". We can't put a date on it. It's nearly ready though. My latest PR we were discussing above has landed so we are very very close. |
# Conflicts: # homeassistant/components/homekit_controller/humidifier.py
There was a problem hiding this comment.
Brilliant! Looks great.
There are a couple of things I hope we can tweak in the future but they rely on more work being done elsewhere so a really not for this PR:
- Given there are only 5 "target humidities" - it would be nice if we could set the "step" size somewhere that the HA UI (and HomeKit) could use to tweak their UI accordingly.
- I really need to get round to switching the tests to have direct access to the underlying aiohomekit model.
Before I approve this though I do have on further thought about whether this is the right way to model your device. It seems that it doesn't have a target humidity, right? So even if they model it as a HomeKit Humidifier the question is, is it actually a Home Assistant humidifier? In the most general sense the higher your target humidity the wetter things will get, and thats certainly true of the spray level. But it's not a target humidity. It won't turn off when it reaches the target.
Do you think https://github.com/home-assistant/core/pull/42735/files would actually be a better fit when its merged (looks like its close)?
| await self.async_put_characteristics( | ||
| { | ||
| CharacteristicsTypes.Vendor.VOCOLINC_HUMIDIFIER_SPRAY_LEVEL: humidity | ||
| / 20 |
There was a problem hiding this comment.
I think aiohomekit clamps this to the minStep automatically so this never sends floats right?
| """Define the homekit characteristics the entity cares about.""" | ||
| return [ | ||
| CharacteristicsTypes.ACTIVE, | ||
| CharacteristicsTypes.RELATIVE_HUMIDITY_CURRENT, |
There was a problem hiding this comment.
It doesn't look like these are all used, can we trim them out?
|
Interesting! If that's the case (and unless there is not a good reason not to) i'd prefer to use the standard humidifier code for this device then, and instead look at adding a number integration to control the spray level when that PR is merged. This spray level control would be in addition to the default humidifier controls. I'll need to do some cleanup to unlock this in homekit_controller as well (currently can't easily have 2 entities of different types for the same homekit service - some of the cleanup for this has already started to land, i'll try and get the rest done asap). |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Proposed change
This adds a vendor specific HomeKit device, the VOCOLinc FLOWERBUD. When you pair this with HomeKit, it is exposed as a humidifier, with a vendor specific characteristic to control the spray level. We use this instead, since this
RELATIVE_HUMIDIFIER_THRESHOLDdoesn't actually do anything.This PR will be ready when there's a new release in the aiohomekit library and when this PR is merged.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: