Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undefined should be returned when no classes are needed #182

Closed
jakubsadura opened this issue Nov 1, 2018 · 2 comments
Closed

undefined should be returned when no classes are needed #182

jakubsadura opened this issue Nov 1, 2018 · 2 comments
Labels
breaking change bug

Comments

@jakubsadura
Copy link

jakubsadura commented Nov 1, 2018 •
edited
Loading

It's quite common that we do not have any class name to be added to DOM, in such case returning undefined would allow having cleaner DOM, without empty class attributes.

Example with React's jsx:

const isFoo = false;
const isBar = false;
const classes = classNames({
  'foo': isFoo,
  'bar': isBar,
});

return (<i className={classes}/>);

results in:
<i class=""/>

while it should be:
<i/>

@see facebook/react#1448
@jakubsadura jakubsadura mentioned this issue Nov 1, 2018
Closed
@vladshcherbin vladshcherbin mentioned this issue Feb 23, 2019
Closed
@kylemh kylemh mentioned this issue Apr 18, 2019
Closed
@DiscoNova
Copy link

DiscoNova commented Oct 14, 2019 •
edited
Loading

I may be commenting the obvious on this old PR, but this simply will not work on various cases where classnames is still supposed to do its thing while not introducing unexpected classes to elements.

For example ... document.documentElement.classList.add(undefined) leads to, you may have guessed it ... <html class="undefined"> - which quite likely isn't what the author of the code intended.

@dcousens
Copy link
Collaborator

See #183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

return undefined for empty class list jakubsadura/classnames
3 participants
@dcousens @jakubsadura @DiscoNova