Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce test warnings due to jim, prompt #99

Merged
merged 5 commits into from
May 24, 2021
Merged

reduce test warnings due to jim, prompt #99

merged 5 commits into from
May 24, 2021

Conversation

JeffFessler
Copy link
Owner

The test suite was using MIRT.jim instead of MIRTjim.jim and that led to a lot of noisy warnings.
Likewise for prompt.
This PR has the tests mostly use the MIRTjim versions so that there are just a few warnings.

It also eliminates a no-longer-needed workaround related to the windows rm issue
#58

There are no changes to src/ except for comments, so no version bump.

@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #99 (d5e4017) into master (5166701) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #99   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files          44       44           
  Lines        2172     2172           
=======================================
  Hits         2168     2168           
  Misses          4        4           
Impacted Files Coverage Δ
src/fbp/image_geom.jl 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5166701...d5e4017. Read the comment docs.

@JeffFessler JeffFessler merged commit 4a0e787 into master May 24, 2021
@JeffFessler JeffFessler deleted the jim-quiet branch May 24, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant