Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added digiboard, digilines keyboard which uses channel keyboard #4

Closed
wants to merge 1 commit into from

Conversation

bas080
Copy link

@bas080 bas080 commented Jul 23, 2013

Should the keyboard channel be configurable?

@Jeija
Copy link
Collaborator

Jeija commented Jul 23, 2013

Yes, the channel should be configurable. But looks good otherwise... Great work!

@lordcirth
Copy link
Contributor

My digipad mod at
https://github.com/lordcirth/minetest-digipad
has a similar keyboard. Perhaps you should consider merging any upgrades - including your better textures - into my version, then we could submit the keyboard, digipad, etc in one pull request?

@Jeija
Copy link
Collaborator

Jeija commented Sep 5, 2013

I currently can't check if this really works until I'm back in my ordinary working environment, but the code looked fine when quickly reviewing it.
Could you please then team up with lordcirth and rename it to digiline_*, then I will merge it for sure.

@lordcirth
Copy link
Contributor

I'm not seeing a LICENSE.txt anywhere in digilines, Jeija could you please add one? Thanks.
I'm now working on switching bas080's textures into my mod, then I'll see if there are any other improvements to merge.

@Jeija
Copy link
Collaborator

Jeija commented Sep 7, 2013

Just added the LICENSE.txt file, thanks for contributing to the project.

@Jeija
Copy link
Collaborator

Jeija commented Apr 24, 2014

I'd love to have something like this, do you have a version that supports changing the channel?
I would then merge this.

@lordcirth
Copy link
Contributor

Ah, you are alive. I haven't played with Minetest in ages, but I'll take a look at my old repos. I can probably add channel switching trivially. When house power comes back, anyway :P

@lordcirth
Copy link
Contributor

Ok, so power is back :) I'm fixing some bugs in keyboard and terminal, starting on channel switching soon. I'm trying to unite as much of the backend code between the two as possible.

@lordcirth
Copy link
Contributor

Ok, I have all the code fixed up, it has lots more features and less bugs :) Just need to update the textures to use bas080's, because mine are placeholders and suck. I am bad with textures, so if someone wants to speed up the process and submit the pull request, that would be cool too.

@Jeija
Copy link
Collaborator

Jeija commented Feb 14, 2015

Nothing much happening here anymore, feel free to create another issue with up-to-date code including the changes I recommended.

@Jeija Jeija closed this Feb 14, 2015
@C1ffisme
Copy link

I made something like this that still works, maybe I should make a pull request, once I get a hang of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants