-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] 5.3.2 Exception in text.js #7887
Comments
If the example code is copy / pasted, it does nothing |
Hi @CodaCodr is there some missing code that invokes those macros? Is this a regression? Does the same problem occur in, say, 5.27: |
Sorry, @pmario @Jermolene: That code was meant to be informative, not demonstrative. It was 01:30 here at the time I posted, had I been less sleepy, I may have posted on Talk, instead, as it's not easy to make it work on tw .com
From my perspective, yes, absolutely. I think that code goes back to 5.1.15 ish. My concern was, in Next, I took out the Hope that's a little clearer. |
Not really. We need some code, that -- if copy / pasted to tw-com works and allows us to reproduce the problem. I did create a button with But nothing happens using FireFox Windows 11 |
I'll keep hacking away at it and close this when I have working code that can be compared side-by-side with the non-working code. |
You don't need to respond unless you see something that grabs your attention. This is just my debugging story. Latest code is...
points:
The So that looks to me that a setTimeout (tick) happens in popup.js and blows up -- which leaves me thinking, there isn't anything I can do directly that might alter that outcome. Except... Many moons ago, that list was producing |
Actions moved to old-skool child elements inside the button...
Same issue. |
On a whim, I used Eric's I'm guessing, "faulty |
Having replaced the popup with a I can see that all the obvious code associated with the select element seems to be executing correctly (various renderings and even the change event being dispatched. Having previously set the debugger to pause on exceptions and then let it run on (clicked play) there's a short pause and then this, in text.js As you can see, |
Another late night debugging session. The problem is a select element further along in the node tree. If I remove that select, everything works. Strangely, the select contains static data... more later. |
Recall that the original code contained a popup. When the popup (menu) was revealed, and an item from the list was chosen, the RSOE appeared. Very easy to be deceived as to where the problem lies... The popup was then replaced with a $select. It suffered the same problem. While I was pondering this bug, and having realized that since the exception was occurring during the refresh cycle (see screenshots above), I decided to bite the bullet and step through it, best I could. Yes. Tedious. But it had to be done. Eventually I got to the problem select element -- which turned out to be a completely different select element to the select element used as a replacement for the original popup menu. @Jermolene This is the select element in question.
And keep in mind:
You can see also, where I commented out a macro that used to transclude that $select code. Made no difference. You can also see I removed In the image below, the select (formerly a popup) is marked If I have any stamina left, I may replace that whole UI with a series of radios and see what that does. |
@CodaCodr As part of other updates to the widget code, the select widget needed to be largely refactored and modernized in v5.3.2 and I suspect these two lines got accidentally swapped around by me while moving code around: Try swapping those two lines around and see if that resolves the issue. |
@saqimtiaz the exception occurs inside text.js. If I step back through the stack I do indeed reach the select: So, the |
|
I'm on the mend from a nasty cold, I can look into this properly in a few days to test if the render and refresh logic has changed due to the refactoring. In the meantime if you have managed to figure out a minimal test case to recreate the problem, that will be very helpful. |
I should have mentioned before, this code is part of a bundle of 900+ tiddlers. Working fine in 5.2.x --> 5.3.1 Said another way, you are correct to be looking for a change in 5.3.2. |
Ugh. I should have caught this before release. Try changing |
@CodaCodr could you please leave this open until we get a fix merged? Thank you |
Describe the bug
The following (very old!) code issues a RSOE in 5.3.2
TiddlyWiki breaks at
<$text text=<<cap>>/>
TiddlyWiki Configuration
The text was updated successfully, but these errors were encountered: