Remove the x-requested-with header from the tm-http-request message
#8148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extraneous headers can interfere with CORS validation when hitting external APIs, due to tightly configured `Access-Control-Allow-Headers` headers. Until there's a way to disable these headers, it's probably better (i.e. most flexible) to expect users to set them deliberately. In this case, I ran into an API that uses cors and the above header, and was unable to make a request to it without making the changes in this PR. I'm also open to modifying the message to allow disabling these headers, but this was the simplest solution I could come up with.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mklauber
changed the title
x-requested-with header from the tm-http-request message
|
Hi @mklauber I think that is reasonable, however we would also need to adjust tiddlywebadaptor.js to manually set the I think that any existing user code hitting a TW-based API would fail with this change. Perhaps instead of removing the header we could add a flag for explicitly disabling it? Ideally, we'd also expose that flag to user code via the |
|
I suggest setting a flag to only use explicit headers. I can try to write that, it may take me a few days. |
|
replaced with #8152 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extraneous headers can interfere with CORS validation when hitting external APIs, due to tightly configured
Access-Control-Allow-Headersheaders. Until there's a way to disable these headers, it's probably better (i.e. most flexible) to expect users to set them deliberately.In this case, I ran into an API that uses CORS and the above header, and was unable to make a request to it without making the changes in this PR. I'm also open to modifying the message to allow disabling these headers, but this was the simplest solution I could come up with.