[Forwardport] Correctly save Product Custom Option values #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lied on shipping - added functional test to cover the bug fix
…lied on shipping - updated correct testCaseId
…leanup after account edit
… using match by products rule - clone category IDs MC-2269: [Visual Merchandiser] Admin should be able to assign products using match by products rule - sku equal MC-2270: [Visual Merchandiser] Admin should be able to assign products using match by products rule - name contains MC-2275: [Visual Merchandiser] Admin should be able to assign products using match by products rule - price and quantity - added mftf tests (cherry picked from commit c1a53ac)
… a percentage of original (for simple product) - Includes MC-60, MC-69, and MC-93
… a percentage of original (for simple product) - Reindex for ee stability
… a percentage of original (for simple product) - Flush cache after reindexing
…roduct position in the category by editing Position field in grid mode - move in the middle within same page - added mftf tests
…rt without selecting options
…rt without selecting options - Fixed code review feedback
…_Sales and Magento_Paypal magento#16698 - Merge Pull Request magento#16698 from mageprince/magento2:mageprince-2.3-patch-fix-sales-paypal - Merged commits: 1. f4496e9 2. a6a0d5b
…_Theme, Magento_Newsletter and Magento_Tax magento#16699
…_Sales and Magento_Paypal magento#16698
…s when amount less than group size magento#16588
[borg] MAGETWO-91710: Creditmemo Grand Total is incorrect if discount is applied on shipping
…kout-configurable
…nto#16569 - Merge Pull Request magento#16569 from arnoudhgz/magento2:feature/make-related-products-in-checkout-configurable - Merged commits: 1. 516566a 2. adcb99d
… name generation
Accepted Public Pull Requests: - magento/graphql-ce#114: Mutations Prototype (POC) magento#74 (by @paliarush) - magento#16699: Declare module namespace before template path in Magento_Theme, Magento_Newsletter and Magento_Tax (by @mageprince) - magento#16701: Declare module namespace before template path in all other modules (by @mageprince) - magento#16698: Declare module namespace before template path in Magento_Sales and Magento_Paypal (by @mageprince) - magento#16687: [Forwardport] Corrected function comment (by @sanganinamrata) - magento#16663: [Forwardport] Fixed Issue magento#11354 Merged CSS file name generation (by @mageprince) - magento#16588: [Forwardport] Fix of invalid price for integer currencies when amount less than group size (by @vkublytskyi) - magento#16562: [Forwardport] Coupon API not working for guest user (by @gelanivishal) - magento#16630: [Forwardport] Small refactoring to better code readability (by @ronak2ram) - magento#16613: Update Israeli ZIP code mask, 7 digits instead of 5 ,according to the� (by @gelanivishal) - magento#16569: Make it possible to disable cross-sell on cart page (by @arnoudhgz) - magento#16487: [Forwardport] Prevent layout cache corruption in edge case (by @gelanivishal) Fixed GitHub Issues: - magento#11354: Merged CSS file name generation (reported by @pmoreno1980) has been fixed in magento#16663 by @mageprince in 2.3-develop branch Related commits: 1. 2816764 2. 2d31c1d 3. e7677e8 4. ca3c79c 5. 311f8ca 6. 1782c54 7. 94e0e25 8. 831e58c 9. 742ad8c - magento#11717: Wrong price amount on product page (reported by @HirokazuNishi) has been fixed in magento#16588 by @vkublytskyi in 2.3-develop branch Related commits: 1. e2c4aca - magento#14056: Coupon API not working for guest user (reported by @gnanasekaranl) has been fixed in magento#16562 by @gelanivishal in 2.3-develop branch Related commits: 1. 1acd06f 2. 2651be3
[borg] MAGETWO-64854: Incorrect Refund Logic with Enterprise Rewards can allow for double-refunds
JeroenVanLeusden
pushed a commit
that referenced
this pull request
Dec 12, 2018
magento 2.3-develop:update branch
JeroenVanLeusden
pushed a commit
that referenced
this pull request
Jan 21, 2019
latest Pull 2.3 Develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#13569
Description
This occurred because the same value object is used for saving all values. After the save
updateStoredData()is called and is used inprepareDataForUpdate().https://github.com/magento/magento2/blob/3561b6614eeafb70cbcbf0dc0254359b857af3d4/lib/internal/Magento/Framework/Model/ResourceModel/Db/AbstractDb.php#L718-L733
Fixed Issues (if relevant)
Manual testing scenarios
Changes Appearancecheckboxes and save product.Contribution checklist