Fixed discrepancy with @return section of DocBlock comments #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ustomer_Model_Customer::cleanAllAddresses()
|
@Nayjest Closing as complete. Thank you. |
magento-team
added a commit
that referenced
this pull request
Nov 12, 2012
* Framework changes
* Added dependency injection of framework capability
* Adopted Zend\Di component of Zend Framework 2 library
* Implemented object manager in Magento application
* Refactored multiple base classes to dependency injection principle (dependencies are declared in constructor)
* Themes/View
* Implemented storing themes registry in database, basic CRUD of themes, automatic registration of themes in database from file system out of the box
* Renamed `Mage_Core_Model_Layout_Update` into `Mage_Core_Model_Layout_Merge`, the former becomes an entity domain model. Similar changes with `Mage_Core_Model_Resource_Layout` -> `Mage_Core_Model_Resource_Layout_Update`, `Mage_Core_Model_Layout_Data` -> `Mage_Core_Model_Layout_Update`
* Performance tests
* Improved indexers running script `dev/shell/indexer.php` to return appropriate exit code upon success/failure
* Implemented running the same performance scenario file with different parameters
* Slightly refactored framework class `Magento_Performance_Testsuite_Optimizer` for better visibility of algorithm
* Visual design editor
* Added ability to remove elements in editor UI
* Revised history of changes VDE toolbar and algorithm of "compacting" operations (moving, removing elements) as a layout update XML
* Added selection of themes to VDE launcher page
* Refactored JavaScript of some UI elements to jQuery:
* "Simple" and "configurable" product view pages
* "Create Account" page
* "Shopping Cart" page
* CAPTCHA
* Newsletter subscription
* Tax management UX improvements
* Split Basic and Advanced Settings for Tax Rule Management UI
* Moved the Import/Export functionality to Tax Rate page
* Moved Tax menu to System from Sales
* Implemented the editable multiselect JavaScript component
* Added mentioning sitemap in `robots.txt` after generation
* Removed creation of DB backup in integration testing framework
* Fixed logic of order of loading ACL resources in backend
* Fixed JavaScript error during installation when one of files in `pub/media` is not writable
* Fixed structure of legacy test fixtures that allowed ambiguous keys in declaration
* Fixed inability to restore admin password when CAPTCHA is enabled
* Various minor UX fixes (labels, buttons, redirects, etc...)
* GitHub requests:
* [#59](#59) -- implemented handling of unexpected situations in admin/dashboard/tunnel action
* [#66](#66)
* refactored ImageMagick adapter unit test to avoid system operation
* simplified unit testing framework -- removed unused classes, simplified handling logic of directory `dev/tests/unit/tmp` and removed it from VCS
* [#73](#73), [#74](#74) -- fixes in docblock tags
* [#75](#75), [#96](#96) -- fixed translation module contexts in a few places
* [#80](#80) -- fixed some runtime errors in import/export module
* [#81](#81) -- removed usage of "remove" directive in places where it is overridden by setting root template anyway
* [#87](#87) -- changed paths of files to include from relative into absolute in `dev/shell/indexer.php` and `log.php`
* [#88](#88) -- provided comments for values that can be configured in `app/etc/local.xml` file
* [#90](#90) -- slightly optimized logic of implementation of loading configurable product attributes
magento-team
pushed a commit
that referenced
this pull request
Feb 6, 2015
…_in_Developer_module [API] MAGETWO-33489: Wrong di.xml in Magento_Developer module
magento-team
pushed a commit
that referenced
this pull request
Mar 23, 2016
JS-355: Video image should be shown while video is loading in fullscreen
ghost
mentioned this pull request
phoenix128
added a commit
to phoenix128/magento2
that referenced
this pull request
Apr 22, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Apr 25, 2018
magento-engcom-team
added a commit
that referenced
this pull request
Apr 25, 2018
Accepted Public Pull Requests: - #14812: [Forwardport] Fixed setting of triggerRecollection flag (by @ihor-sviziev) - #14805: Fix for issue 911 found on MSI project - Cannot read property source_� (by @phoenix128) - #14775: MSI-920: Fixed incorrect test (during order cancellation) (by @seruymt) - #14846: Updated readme.md file 2.3-develop (by @sidolov) - #14834: Remove unused namespace from Ui Export model (by @williankeller) - #14842: For MSI-377: fix test fixture and mark return processor as @api (by @seruymt) - #14806: FIX for MSI issue #74 on qty increment (by @phoenix128) Fixed GitHub Issues: - #9580: Quote Attribute trigger_recollect causes a timeout (reported by @bh-ref) has been fixed in #14812 by @ihor-sviziev in 2.3-develop branch Related commits: 1. d0ceba3
ghost
mentioned this pull request
magento-engcom-team
pushed a commit
that referenced
this pull request
Jul 12, 2018
- Added mutation support - Added GraphQL functional test as an example of how to add mutations
magento-engcom-team
pushed a commit
that referenced
this pull request
Jul 12, 2018
- Added temporary placeholder field to Mutations
magento-engcom-team
added a commit
that referenced
this pull request
Jul 12, 2018
- Merge Pull Request magento/graphql-ce#114 from magento/graphql-ce:grqphql-mutations-74 - Merged commits: 1. db3f2c7 2. eb2a5a3
magento-engcom-team
pushed a commit
that referenced
this pull request
Jul 12, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Jul 12, 2018
Accepted Public Pull Requests: - magento/graphql-ce#114: Mutations Prototype (POC) #74 (by @paliarush) - #16699: Declare module namespace before template path in Magento_Theme, Magento_Newsletter and Magento_Tax (by @mageprince) - #16701: Declare module namespace before template path in all other modules (by @mageprince) - #16698: Declare module namespace before template path in Magento_Sales and Magento_Paypal (by @mageprince) - #16687: [Forwardport] Corrected function comment (by @sanganinamrata) - #16663: [Forwardport] Fixed Issue #11354 Merged CSS file name generation (by @mageprince) - #16588: [Forwardport] Fix of invalid price for integer currencies when amount less than group size (by @vkublytskyi) - #16562: [Forwardport] Coupon API not working for guest user (by @gelanivishal) - #16630: [Forwardport] Small refactoring to better code readability (by @ronak2ram) - #16613: Update Israeli ZIP code mask, 7 digits instead of 5 ,according to the� (by @gelanivishal) - #16569: Make it possible to disable cross-sell on cart page (by @arnoudhgz) - #16487: [Forwardport] Prevent layout cache corruption in edge case (by @gelanivishal) Fixed GitHub Issues: - #11354: Merged CSS file name generation (reported by @pmoreno1980) has been fixed in #16663 by @mageprince in 2.3-develop branch Related commits: 1. 2816764 2. 2d31c1d 3. e7677e8 4. ca3c79c 5. 311f8ca 6. 1782c54 7. 94e0e25 8. 831e58c 9. 742ad8c - #11717: Wrong price amount on product page (reported by @HirokazuNishi) has been fixed in #16588 by @vkublytskyi in 2.3-develop branch Related commits: 1. e2c4aca - #14056: Coupon API not working for guest user (reported by @gnanasekaranl) has been fixed in #16562 by @gelanivishal in 2.3-develop branch Related commits: 1. 1acd06f 2. 2651be3
5 tasks
5 tasks
5 tasks
5 tasks
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed discrepancy with @return section of DocBlock comments in Mage_Customer_Model_Customer::cleanAllAddresses()