Fix DesktopDropdownMenuPositionProvider to align with the correct horizontal side of the window
#555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…izontal side of the window.
m-sasha
force-pushed
the
m-sasha/dropdown-menu-positioning
branch
from
044d286
to
3afd661
Compare
MatkovIvan
approved these changes
May 11, 2023
...se/material/material/src/desktopMain/kotlin/androidx/compose/material/DesktopMenu.desktop.kt
Outdated
Show resolved
Hide resolved
m-sasha
force-pushed
the
m-sasha/dropdown-menu-positioning
branch
from
536f951
to
0fdcc83
Compare
igordmn
pushed a commit
that referenced
this pull request
Jun 8, 2023
…orizontal side of the window (#555)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DesktopDropdownMenuPositionProvider currently implements a discontinuous choice for horizontally positioning the dropdown relative to its anchor. Specifically, if the desired horizontal position (aligned with the left of the anchor) doesn't fit in the screen, it will align the dropdown with the right of the window. This is wrong if the reason it doesn't fit is because the anchor is at negative coordinates.
Proposed Changes
Fix
DesktopDropdownMenuPositionProviderto provide a continuous function when positioning the dropdown horizontally:Also take into account the option of RTL layout, where the preferred position is to align the dropdown with the right of the anchor.
Testing
Test: Added a few new unit tests.
Issues Fixed
Fixes: JetBrains/compose-multiplatform#3129