Improve malformed identifiers handling in -ren=1 mode
#709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Maccimo thank you. Could you please update the PR so that it doesn't change formatting in |
…nit tests for `ConverterHelper` class.
Maccimo
force-pushed
the
java-decompiler-ignorable-chars
branch
from
c1f2257
to
5ea28c3
Compare
|
@trespasserw I've updated PR, please review. |
Actuarius
pushed a commit
to MinecraftForge/FernFlower
that referenced
this pull request
Jan 31, 2018
Actuarius
pushed a commit
to MinecraftForge/FernFlower
that referenced
this pull request
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch propose following improvements to the default renaming functionality:
All identifiers should be compliant to the JLS9 section 3.8 and SHOULD NOT contains so-called "ignorable" characters.
Ignorable characters are silently removed by javac during the compilation and thus may appear only in specially crafted obfuscated classes.
For more information about "ignorable" characters see JDK-7144981.
Add dedicated unit tests for
org.jetbrains.java.decompiler.modules.renamer.ConverterHelperclass.