Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Clarify Dart's closing label by changing it to an End symbol. #893

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jinlongchen
Copy link

The original closing label in Dart uses a comment which may not be clear to developers. To improve clarity, I propose changing the closing label to an End symbol. This will make it more easily recognizable and reduce confusion in code.

…he original closing label in Dart uses a comment which may not be clear, To improve clarity, I propose changing the closing label to an End symbol. This will make it more easily recognizable and reduce confusion in code.
@alexander-doroshko alexander-doroshko self-assigned this Jun 8, 2023
@alexander-doroshko
Copy link
Member

Thank you for the pull request. Can you please add the screenshots to the PR description with the suggested change (both light and dark themes)?

Is ⦿ a well-known "end symbol"?

I'm not sure if all fonts support this symbol nicely.

I'm also thinking about a different approach of addressing the confusion. I mean making it look not as a comment but as an inlay hint. Example from Kotlin:
image

As a bonus, inlay hints have context menu that allows disabling them.

@alexander-doroshko
Copy link
Member

Jsut for the reference, here's another example from Kotlin, pretty much the same as Dart closing labels:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants