Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button styles #27

Closed
wants to merge 1 commit into from
Closed

Button styles #27

wants to merge 1 commit into from

Conversation

HEXOGEN616
Copy link
Contributor

@HEXOGEN616 HEXOGEN616 commented Oct 20, 2018 •
edited by JianLoong
Loading

Change buttons to bootstrap styles

Handles issue #15

@HEXOGEN616
Button styles
3aa07ef 
Change buttons to bootstrap styles
JianLoong
JianLoong reviewed Oct 20, 2018
View reviewed changes
Solutions/FIT5032_Week04_DatabaseFirst/FIT5032_W4_DatabaseFirst/Views/Units/Index.cshtml
@Html.ActionLink("Edit", "Edit", new { id=item.Id }) |
@Html.ActionLink("Details", "Details", new { id=item.Id }) |
@Html.ActionLink("Delete", "Delete", new { id=item.Id })
@Html.ActionLink("Edit", "Edit", new { id=item.Id }, new { @class = "btn btn-default", @style = "width: 80px" })
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @sprintal

Please avoid using inline styles. When you do an @Style it would create an inline style. Normally, it is a good idea to avoid inline styles. It would be much better to not use inline style in this scenario.

Refer to
Quora
MDN Link

Regards,

Jian

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion, I will revise accordingly.

@HEXOGEN616 HEXOGEN616 closed this Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JianLoong JianLoong JianLoong left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HEXOGEN616 @JianLoong