Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom server URL fails #69

Closed
johnhtodd opened this issue Sep 19, 2018 · 3 comments
Closed

Custom server URL fails #69

johnhtodd opened this issue Sep 19, 2018 · 3 comments

Comments

@johnhtodd
Copy link

Attempting to enter a custom server URL does not permit entry. The "OK" button never lights even after a valid https:// URL is entered (try "https://dns.quad9.net")

@cjhenck
Copy link
Contributor

cjhenck commented Sep 19, 2018

Thanks John - do you still see the error if you add a path to the end? (e.g. "https://dns.quad9.net/") We were trying to follow the DOH spec, which as I understand it requires a path, but perhaps we could provide better error information. If it still doesn't work with a path we will need to investigate further.

@johnhtodd
Copy link
Author

That's the trick. Trailing / is required on hostname before other components like "dns-query". Sorry for the false alarm - I was trying to test null cases and got stumped on my first attempt by the UI.

@cjhenck
Copy link
Contributor

cjhenck commented Sep 20, 2018

No worries, thanks for providing the feedback. I created another issue for the user experience, since I think we can do better with the messages we provide.

@cjhenck cjhenck closed this as completed Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants