Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.16.5mohist] command /openender unavailable #59

Closed
luoxiawuchen opened this issue Jan 24, 2022 · 5 comments
Closed

[1.16.5mohist] command /openender unavailable #59

luoxiawuchen opened this issue Jan 24, 2022 · 5 comments
Labels

Comments

@luoxiawuchen
Copy link

image
image

[19:17:20 WARN]: java.lang.InstantiationException: Unable to create a new ISpecialEnderChest: null
[19:17:20 WARN]: at com.lishid.openinv.util.InternalAccessor.newSpecialEnderChest(InternalAccessor.java:196)
[19:17:20 WARN]: at com.lishid.openinv.OpenInv.getSpecialEnderChest(OpenInv.java:216)
[19:17:20 WARN]: at com.lishid.openinv.commands.OpenInvCommand.openInventory(OpenInvCommand.java:165)
[19:17:20 WARN]: at com.lishid.openinv.commands.OpenInvCommand.access$100(OpenInvCommand.java:34)
[19:17:20 WARN]: at com.lishid.openinv.commands.OpenInvCommand$1$1.run(OpenInvCommand.java:92)
[19:17:20 WARN]: at org.bukkit.craftbukkit.v1_16_R3.scheduler.CraftTask.run(CraftTask.java:98)
[19:17:20 WARN]: at org.bukkit.craftbukkit.v1_16_R3.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:462)
[19:17:20 WARN]: at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:1060)
[19:17:20 WARN]: at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:334)
[19:17:20 WARN]: at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:1006)
[19:17:20 WARN]: at net.minecraft.server.MinecraftServer.func_240802_v_(MinecraftServer.java:821)
[19:17:20 WARN]: at net.minecraft.server.MinecraftServer.func_240783_a_(MinecraftServer.java:269)
[19:17:20 WARN]: at java.base/java.lang.Thread.run(Thread.java:829)

I tested on paper without this problem
Personally, I still hope to fix this error
But I know it may not be reasonable
Anyway, thank you for developing and sharing this excellent plugin
Thank you for your patience

@Jikoo
Copy link
Owner

Jikoo commented Jan 24, 2022

There should be further logs for the error (i.e. Caused by SomeException). This is presumably a missed mapping in Mohist, but without more info they won't be able to fix it.

I am going to close this as it probably isn't a problem OI will be addressing. Mohist is already committed to fixing issues with plugins using NMS on their end and 1.16 is no longer a supported version.

@Jikoo Jikoo closed this as completed Jan 24, 2022
@Jikoo Jikoo added the wontfix label Jan 24, 2022
@Jikoo
Copy link
Owner

Jikoo commented Jan 24, 2022

For reference, error line is a re-thrown error, so there is guaranteed to be further info in the trace

throw new InstantiationException(String.format("Unable to create a new ISpecialEnderChest: %s", e.getMessage()));

@luoxiawuchen
Copy link
Author

For reference, error line is a re-thrown error, so there is guaranteed to be further info in the trace

throw new InstantiationException(String.format("Unable to create a new ISpecialEnderChest: %s", e.getMessage()));

OK, thanks for your reply

@Jikoo
Copy link
Owner

Jikoo commented Jan 24, 2022

Er wait, I'm an idiot, there is guaranteed not to be any further info in the trace due to the way I did it. Rough, hm. Going to reopen this for future versions I guess.

@Jikoo Jikoo reopened this Jan 24, 2022
@Jikoo Jikoo closed this as completed in 3aa3139 Jan 27, 2022
@Jikoo Jikoo added bug and removed wontfix labels Jan 27, 2022
@Jikoo
Copy link
Owner

Jikoo commented Jan 27, 2022

Usually I say you're SOL using older versions, but since it literally takes 5 seconds to cherry pick the commit I did do it for this case. You can download a build backporting the trace change from this action run (the dist artifact at the bottom will be a zip file containing the jar) which you then ideally can use to provide the Mohist devs with the info about which mapping needs to be fixed to support OI.

/e actually helps to link the action run, whoops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants