New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The theme mode is not persistent #8

Closed

soullivaneuh opened this issue Nov 7, 2023 · 1 comment · Fixed by #14

Assignees

Collaborator

soullivaneuh commented Nov 7, 2023 •

edited

Loading

Summary

Steps to reproduce

Open the website
Change the theme to the dark mode
Close the website tab
Open the website again on a fresh new tab

Current behavior

The theme is back to light mode.

Expected behavior

The theme should be kept in dark mode as it was previously chosen.

Possible fixes

We should find a way to save the current theme state under localstorage or session.

Vendor issue: sylhare/Type-on-Strap#404

Related

Theme mode default to web browser settings #7

soullivaneuh self-assigned this

Collaborator Author

soullivaneuh commented Nov 7, 2023

Should be solved by sylhare/Type-on-Strap#406.

soullivaneuh mentioned this issue

feat: dark mode improvements #14

Merged

Jimmynovaaa closed this as completed in #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment