Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use semantic versioning for script version #125

Closed
mrstux opened this issue Apr 24, 2024 · 2 comments
Closed

Use semantic versioning for script version #125

mrstux opened this issue Apr 24, 2024 · 2 comments

Comments

@mrstux
Copy link
Contributor

mrstux commented Apr 24, 2024

Hi,

I think it would be good if jailmaker used semantic versioning.

https://semver.org

ie major.minor.patch, where patch is incremented for fixes/improvements... minor is incremented for additional features, and major is incremented for breaking changes.

Looking at the release history, 1.1.4 should've been 1.2.0, and 1.1.5 should've been 1.3.0 ;)

It seems like prior to 1.1.4 everything was semantically versioned ;)

This would make it clearer to users how deeply they need to investigate the change notes... after all adding zfs dataset support is a fairly big deal, and there's a migration involved to take advantage of the feature... its not just a bug fix patch ;)

And when you remove deprecations, that becomes a breaking change... which is the time to add other breaking changes. And then you have 2.0 ;)

@Jip-Hop
Copy link
Owner

Jip-Hop commented Apr 24, 2024

Ah yes thanks for reminding me. My plan was to follow this scheme but I dropped the ball. For breaking changes I'll definitely bump the major version and I'll try to keep the minor version in mind.

@Jip-Hop
Copy link
Owner

Jip-Hop commented Apr 24, 2024

Corrected with latest release: https://github.com/Jip-Hop/jailmaker/releases/tag/v1.2.0

@Jip-Hop Jip-Hop closed this as completed Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants