Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated tests #86

Open
Jip-Hop opened this issue Feb 13, 2024 · 4 comments
Open

Automated tests #86

Jip-Hop opened this issue Feb 13, 2024 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Jip-Hop
Copy link
Owner

Jip-Hop commented Feb 13, 2024

Create automated unit/integration tests to test jailmaker during development. Ideally these tests would run, bare metal, on TrueNAS SCALE (and on nightly versions) with an NVIDIA GPU (to test passthrough as well) after pushing to this repo.

Contributions welcome!

@Jip-Hop Jip-Hop added enhancement New feature or request help wanted Extra attention is needed labels Feb 13, 2024
@spusuf
Copy link
Contributor

spusuf commented Feb 14, 2024

I've updated to the 24.04 Dragonfish beta, let me know what I can do to help

@Jip-Hop
Copy link
Owner Author

Jip-Hop commented Jun 29, 2024

Initial setup to automatically test jlmkr.py inside a Ubuntu 24.04 VM using GitHub Actions. See the first successful test run. This could be improved to run more elaborate tests, such as the ones being worked on in #210.

@jonct
Copy link
Contributor

jonct commented Jul 7, 2024

PR #220 may help, pending the output of a test run…

@Jip-Hop
Copy link
Owner Author

Jip-Hop commented Jul 9, 2024

Automated testing is already catching bugs ^^ my attempted fix for #224 caused systemd_nspawn_user_args in config templates to always be overridden (erased) which was causing docker inside the jail to fail. Tests are green again!

https://github.com/Jip-Hop/jailmaker/actions/runs/9856389760/job/27213279151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants