Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

active in all tab & add shake animation switch #6

Closed
wants to merge 3 commits into from
Closed

active in all tab & add shake animation switch #6

wants to merge 3 commits into from

Conversation

faceair
Copy link
Contributor

@faceair faceair commented Nov 29, 2015

No description provided.

@faceair
Copy link
Contributor Author

faceair commented Nov 29, 2015

I‘d prefer to put the enable switches in the configuration rather than starting manually, so that I can use it in every window.

@island205
Copy link

+1

1 similar comment
@tejasmanohar
Copy link

+1

This was referenced Dec 1, 2015
@cakecatz
Copy link

cakecatz commented Dec 1, 2015

+1

4 similar comments
@itkang
Copy link

itkang commented Dec 1, 2015

+1

@victorperin
Copy link

+1

@nerdsupremacist
Copy link

+1

@huytd
Copy link

huytd commented Dec 1, 2015

+1

@dsphper
Copy link

dsphper commented Dec 2, 2015

My solution is almost the same.
I plan to add music effects

@dmpty dmpty mentioned this pull request Dec 2, 2015
@jason19659
Copy link

activate-power-mode.coffee:57
Hide Stack Trace
TypeError: Cannot read property 'appendChild' of null
at Object.module.exports.ActivatePowerMode.setupCanvas (file:///C:/Users/ziywang/.atom/packages/activate-power-mode/lib/activate-power-mode.coffee:43:30)
at Object.module.exports.ActivatePowerMode.subscribeToActiveTextEditor (file:///C:/Users/ziywang/.atom/packages/activate-power-mode/lib/activate-power-mode.coffee:35:6)
at file:///C:/Users/ziywang/.atom/packages/activate-power-mode/lib/activate-power-mode.coffee:16:8
at Emitter.module.exports.Emitter.emit (C:\Users\ziywang\AppData\Local\atom\app-1.2.4\resources\app.asar\node_modules\event-kit\lib\emitter.js:86:11)
at C:\Users\ziywang\AppData\Local\atom\app-1.2.4\resources\app.asar\src\pane-container.js:333:27
at Emitter.module.exports.Emitter.emit (C:\Users\ziywang\AppData\Local\atom\app-1.2.4\resources\app.asar\node_modules\event-kit\lib\emitter.js:86:11)
at Pane.module.exports.Pane.setActiveItem (C:\Users\ziywang\AppData\Local\atom\app-1.2.4\resources\app.asar\src\pane.js:248:22)
at Pane.module.exports.Pane.activateItem (C:\Users\ziywang\AppData\Local\atom\app-1.2.4\resources\app.asar\src\pane.js:312:21)
at atom-tabs.TabBarView.onMouseDown (C:\Users\ziywang\AppData\Local\atom\app-1.2.4\resources\app.asar\node_modules\tabs\lib\tab-bar-view.js:670:19)

@JoelBesada
Copy link
Owner

Thanks! I'll take a closer look at this later this week.

@huanzhang
Copy link

+1

@williamtroy
Copy link

+1

@JoelBesada
Copy link
Owner

This PR will be included in the 0.4.0 release #76. Thank you for your contribution!

@JoelBesada JoelBesada closed this Dec 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.