-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IGC file writer #6
Comments
I hadn't thought of that yet, but you're right that it would be fairly straightforward to add. I'm happy to do so, though feel free to open a PR :) |
@estk do you want to look into that? |
On further thought, implementing formatters for the various record types will actually help with adding property testing, as it enables property tests of the form |
yep, although I'm wondering if the formatters should return Result to in case of invalid values 🤔 |
@Turbo87 - I think it's more idiomatic to make it impossible to create invalid record structs - every sane instance of a record struct has a single well defined string representation. @estk - I started having a look at implementing this over the weekend, I have just opened a WIP PR (#15) to track it. |
yeah, that makes sense to me. just wondering how to implement that. are you thinking about a builder pattern kind of thing? |
Implemented in #15 |
While the README claims that this is only a parser, the low-level nature of the structs seems to make it relatively straight-forward to implement writers for them too. Have you thought about that yet, or is that out-of-scope for this crate?
I'm asking because of the discussion in Turbo87/ogn-web-gateway#11
The text was updated successfully, but these errors were encountered: